Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically fetch mazerunner commands rather than waiting for a button press #215

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Automatically fetch mazerunner commands rather than waiting for a button press #215

merged 6 commits into from
Nov 21, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

Mazerunner was flaking too much when the testing app relied upon a button press to trigger the next command fetch.

Automatically fetch commands instead, like we do in bugsnag-cocoa.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading 

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +1  +0.0%      +1    [__TEXT]
  -0.0%      -1  -0.0%      -1    __TEXT,__objc_methname
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the karl-automatic-mazerunner-fetch branch 2 times, most recently from 52146b9 to b61e6cb Compare November 17, 2023 13:11
@kstenerud kstenerud force-pushed the karl-automatic-mazerunner-fetch branch from b61e6cb to 19e6ad9 Compare November 17, 2023 13:15
@kstenerud kstenerud force-pushed the karl-automatic-mazerunner-fetch branch from bd8b428 to 6ab90ef Compare November 20, 2023 14:32
twometresteve
twometresteve approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nice improvements to the test fixture code structure too.

features/fixtures/ios/Fixture/FixtureConfig.swift Outdated Show resolved Hide resolved
@kstenerud kstenerud merged commit 78a81a1 into next Nov 21, 2023
1 check passed
@kstenerud kstenerud deleted the karl-automatic-mazerunner-fetch branch November 21, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

@tomlongridge tomlongridge Awaiting requested review from tomlongridge

@robert-smartbear robert-smartbear Awaiting requested review from robert-smartbear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstenerud @twometresteve